| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
This commit was manufactured by cvs2svn to create branch 'rel-2-1-patches'.
Added ability to edit Hardcopy Header If passed make_local_copy with any true value, assumes that the file being edited is some type of library or default file that should not be overwritten and the Save button is greyed out. Stopped editor from trying to edit blank files or edit directories as files.
Handle case where setID and probNumber are undefined (e.g. when editing course_info file.)
The bread crum path at the top leads back to the problem being edited, not to the Instructor Tool. This is at least reasonable behavior. This fixes bug #596 --Mike
added permissions checks
When editting a problem, you now have the option of adding it to an existing set.
reworked error messages
changed erronious == to eq. fixes bug #546.
Filename extension of .pg should only be forced for problem files.
If the user does a save as and forgets the .pg, we help them out and append it to the file name.
Get mode list from variable set in global.conf.
Fixed bug in previous version Arnie
Doubled the length of the save as textfield box. Arnie
can't save as with specifying a filename changed some warns to addmessage()
On refresh, make source file path relative to the templates directory. This is needed to match the behavior of alias on static gif files.
now passes success/failure messages to Problem.pm
Added a surePathToFile call when saving a .pg problem. Now they can be saved in a new directory. This is a partial solution to having a read only library. More to come.
Doing 'Save as' on a problem pops up a new PGProblemEditor window. Now the new window contains the newly saved file. Also modified the name of the target window since targets aren't supposed to start with _ (except for the special reserved ones), and so that editting in the new window and clicking on a button like Refresh will open yet another window.
Make editing a file which doesn't exist stop being an error. This gives a way to create course info files and new set headers.
Nicer titles, especially for set header and course info editting.
Added support for editting problems which are not presented as being part of a real set.
Removed warning messages.
Added code to give message when an edited problem file cannot be saved. Some of the problems reported in bug #152 are addressed. Instituting a submit result field was not done.
urlpath/systemlink upgrades LOTS of cleanup (but it still needs more)
changed template escape handler functions to grab data from $r->urlpath instead of @_ for compatability with dispatch_new.
Added rudimentary "Save as" function. This duplicates WW1.9 save as , but does not provide any extra functionality. The following problems remain: The redirect does not yet work correctly. I believe the desired behavior is to view the new saved problem from the editor. There is no easy way to view the new problem or whatever until the problem has been assigned to globalUser in the set.
Made modifications to PG problem editor to allow editing of course_info. Future plans include allowing editing of login_info by the site manager (but not by the course instructors). All files to be edited must lie under the templates directory (for safety reasons.) There are still issues with adequate warnings for saving files when permissions are not correctly set. There is not yet a save as button. --Mike
As best I can determine all "get" commands to the database are now checked and appropriate action (usually "die") is taken if no object is returned. One exception. The multiple "gets" such as getGlobalSets(@setNames) are not checked -- if a given setName is not found is an empty object returned? in the list or is nothing returned? --Mike
Normalized headers. All files now contain the text below as a header. This is important since all files now (a) use the full name of the package, (b) assign copyright to "The WeBWorK Project", (c) give the full path of the file (relative to CVSROOT) instead of simply the file name, and (d) include license and warranty information. Here is the new header: ################################################################################ # WeBWorK Online Homework Delivery System # Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/ # $CVSHeader$ # # This program is free software; you can redistribute it and/or modify it under # the terms of either: (a) the GNU General Public License as published by the # Free Software Foundation; either version 2, or (at your option) any later # version, or (b) the "Artistic License" which comes with this package. # # This program is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the # Artistic License for more details. ################################################################################
Fixed problem in logic which kept an edited problem from reading the .tmp file when the answer was submitted. Now the editMode variable and sourceFilePath variables are passed on as hidden variables by Problem.pm if they exists in the input form. This fixes bug #179 as well as bug #109. The temporary file is now labeled fileName.pg.user.tmp where user is the login name of the person editing the file. If that file exists then pgProblemEditor will attempt to use that as a source file. The revert button forces a read from fileName.pg --Mike
Cosmetic changes to title --Mike
When editing a set header one can not save to a temporary file, (the refresh button is gone) however you can make a permanent change and the result is viewed from the ProblemSet.pm page listing the problems from the set, together with the screen version of the set header. --Mike
Added a link which allows editing of the setHeader Refresh and Save don't yet work because they try to access the set header as problem 0. One fix would be to have Problem.pm display the setHeader whenever it was asked to show problem 0. This involves a fair amount of special case code. Is there are better way? --Mike
Added bread crumbs (path subroutine) along the top of each of these pages. --Mike
now sends editMode=savedFile if the "Save" button is pressed, and doesn't send the "submit_button" parameter.
Added formatting --Mike
Small modifications to correct warning messages when opening the temp file. -- Mike
Filter problem contents before saving to disk to handle line ending problems. All occurences of \r\n and \r are replaced by \n. Began improving the error messages if files cannot not be read.
Parent DirectoryReplacing hard coding of /webwork/ with $ce->{webworkURLs}->{root}
-- Mike
The pgProblemEditor now looks for a global problem record if it cannot find a global_user problem record. -- Mike
Changed explicit references to "/webwork" to the abstract
$ce->{webworkURLs}->{root}. If you've been hardcoding "/webwork" into
your URLs, you should take a look at the diff to this update to learn
the prefered method.
-Dennis
Replaced temporary values placed in $self->{ce}->{foo}
by $self->{foo} in order to avoid editing the course environment
unnecessarily. Fixes bug #35
--Mike
Rearranged the order of functions in PGProblemEditor.pm Removed an extraneous warning from ProblemSetEditor.pm -Dennis
Commented out debugging code in pgProblemEditor --Mike
The pgProblemEditor module now handles the seed and displayMode correctly. -- Mike
Problem Editor now creates a temporary file to edit ( adding .tmp to the file name) Refresh causes a redirect to the Problem.pm with a GET command. Some of the arguments are unnecessary and need to be cleaned up. The seed and display mode in the problem editor are not properly initialized from the problem set. Problem.pm has been modified to check for these arguments and to read the temporary source file, seed and displayMode. These are passed through to a PG.pm object. PG also needed to be modified so that the source_file and seed values are overridden
The problem editor will now edit existing problems in place. You invoke it with http://webwork3.math.rochester.edu:1102/webwork/mth143/instructor/pgProblemEditor/0/2/ and it will edit problem 2 in set 0. It can't edit files directly or create new files. The problems are CHANGED!!! there is no editing in a temporary file-- the problems are changed at every step. BEWARE --Mike
The script now reads takes the form data in problemContents and displays it in a textarea form. If there is no problemContents it reads from the file in template directory. The script is called with .../instructor/pgProblemEditor/set10/prob1 I'm using the current convention for labeling files in the template directory. Using '10' for set10 will not work right at the moment. .pg and the course template directory are combined with the path components to determine the path to the file. It remains to add the rest of the editing buttons and provide a method for saving to the template file. -- Mike
Stub for PGProblemEditor which edits a .pg file -- Mike
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| aubreyja at gmail dot com | ViewVC Help |
| Powered by ViewVC 1.0.9 |