| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
Parent DirectoryHEAD backport: Make sure that $r->param("user") is only called in scalar
context. (gage)
This commit was manufactured by cvs2svn to create branch 'rel-2-1-patches'.
timezone support
added permissions checks
replace submitError with addmessage() call
Cleared commented out code in Stats.pm Fixed error arising when no scoring files were checked. Nows gives a more useful message. This fixes #379
Fixed errors in creating urls. (It is important to set authen=>0 when creating links for forms -- they already contain hidden authentication variables.
More changes in construction of urls. Changed parameter acquistion in ShowAnswers
Cleanup -- moving toward using the Apache:Request object and URLpath. It remains to use URLpath to construct new paths in these files.
Roll back previous changes. The user_id is no longer listed in the scoring files. sorry about that. --Mike
Added user_id (the login id) to the list in scoring.
Changed the size of the font for printing out the results of the scoring file.
This file needs to be reviewed carefully. There is a lot of crufty code.
The use of s{tyle=>'.....' should be replaced by items in the template in
this file and throughout the Instructor modules.
Modified print out so that the problem totals and index totals have %4.1f format. The field width is 4 and the number of decimal points is 1. This closes bug #284 --Mike
- Assigner and SetsAssignedToUser now refuse to unassign sets from the GlobalTableEmulator's "global user". Closes bug #283. - New "unassign from all users" button in Assigner. - Cosmetic changes to path() and title() in several modules.
Multiple users with the same student ID no longer clobber each other. (The users are still sorted by student ID.) Closes bug #285.
moved a comment
I wrote a really great log message, and then I lost it.
So now I'm a little pissed off.
Added code to pre-fetch users, global problems and user problems outside
of the main processing loop of scoreSet(). This allows the use of
getAllGlobalProblems() and getAllUserProblems(), which is much more
efficient than what was being done before:
For a course with 154 problems in 9 sets, all of which are assigned to
all users, scoring all sets with "IncludeIndex" and "Record Scores for
Single Sets" took the following times:
Original code: 34.07 sec
New code: 8.68 sec
This is around four times as fast.
I initially attemped to rewrite the main loop to allow the use of
getAll*Problems(), but this proved to be time consuming and error prone.
I eventually decided to leave the main loop alone, except to replace the
DB calls inside it with accesses to pre-fetched records.
As best I can determine all "get" commands to the database are now checked and appropriate action (usually "die") is taken if no object is returned. One exception. The multiple "gets" such as getGlobalSets(@setNames) are not checked -- if a given setName is not found is an empty object returned? in the list or is nothing returned? --Mike
Normalized headers. All files now contain the text below as a header. This is important since all files now (a) use the full name of the package, (b) assign copyright to "The WeBWorK Project", (c) give the full path of the file (relative to CVSROOT) instead of simply the file name, and (d) include license and warranty information. Here is the new header: ################################################################################ # WeBWorK Online Homework Delivery System # Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/ # $CVSHeader$ # # This program is free software; you can redistribute it and/or modify it under # the terms of either: (a) the GNU General Public License as published by the # Free Software Foundation; either version 2, or (at your option) any later # version, or (b) the "Artistic License" which comes with this package. # # This program is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the # Artistic License for more details. ################################################################################
changed getMergedProblems to getUserProblems. This seems to have speeded things up somewhat. --Mike
Slowly modifying scoring so that it will be easier to add features. The modifications are mainly to the scoreSet function. --Mike
Added button to link to scoring of sets. Removed some debugging warning messages. --Mike
Protected against undefined strings. They are replaced by empty strings. --Mike
Fixed a bug that prevented scoring of sets assigned to fewer than all users
Added the scoringDownload module for downloading scoring data
Added many functions for filtering data out for different files
Inconsequential changes
Fixed a bug preventing scoring data from being generated for sets assigned to less than all users.
Now generates scoring data files in response to requests from the set list. There is no confirmation that this has been done, yet, though. If it returns an "empty" page, it worked, and you can see the scoring files.
The set-scoring code generates all scoring file types available in WW1.9 (normal, full, total).
Now the "totals" column is working.
Generating a scoring file works except for totals, and it can be written out to disk. Still no UI.
Still more bug fixing. I think that should do it for the auxiliary functions.
Lots of bug-fixing to auxiliary routines
Lots of bug-fixes replaced all instances of "column" with the (much) more accurate "row"
And then I wrote comments
Finished the auxiliary functions.
Initial commit, containing support methods.
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| aubreyja at gmail dot com | ViewVC Help |
| Powered by ViewVC 1.0.9 |