| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
This commit was manufactured by cvs2svn to create branch 'rel-2-3-dev'.
Parent DirectoryAdded {} to a couple of CGI::Tr to force concatenation.
Added {} to some HTML tags. For some reason they seem to have disappeared?
Converting from use CGI to use WeBWorK::CGI The only substantial change is in Hardcopy where set_id was changed to "sid" I believe that change is correct.
Try using the -nosticky pragma to see if this fixes the problem.
Correctly handle viewing of edited files (we are passed relative paths, but the code used to treat them as absolute paths).
forward-port from rel-2-2-dev: (move [edit] link for Course/Set Info to top, resolving bug #978.)
forward-port from rel-2-2-dev: (security checks for sourceFilePath -- fixes bug #970.
* Utils.pm: add path_is_subdir
* Problem.pm: use path_is_subdir to check sourceFilePath
fix logic on when to use sourceFilePath
* ProblemSet.pm: use path_is_subdir to check sourceFilePath
add permissions check around sourceFilePath handler
* ProblemSets.pm: use path_is_subdir to check sourceFilePath
* GatewayQuiz.pm: remove code to preserve editMode/sourceFilePath (not used))
forward-port from rel-2-2-dev: (change underscores to spaces in siblings list, add tooltop for overflowing siblings.)
forward-port from rel-2-2-dev: (update copyright date range -- 2000-2006. this is probably overkill, since there are some files that were created after 2000 and some files that were last modified before 2006.)
forward-port from rel-2-2-dev: (make webwork code output siblings div/h2 code, rather than template. this allows for the siblings box to be named according to its contents.)
forward-port: (update info() for new stylesheet.)
forward-port to HEAD (Fixed error in variable names that was breaking the code in HEAD. -gage)
forward-port to head (partial clean up rendering of the info box. it will now not show up unless it has content, and the headings will be rendered more nicely.)
Merge changes with HEAD (Re-target view and edit links to use the view and edit windows)
Merging changes from rel-2-2-dev into HEAD
Gateway update: don't display gateway sets in siblings sidebar of ProblemSet list for all users, regardless of permissions. This may or may not be the desired behavior. I like it because it forces the user to go to a test from the ProblemSets page where we rewrite the link with the more intuitive (but longer) text "Take new [test name] test".
Gateway update: reflect use of listUserSets to list non-versioned sets
make siblings() work better with new template
use new feedbackMacro()
added HiRes timing data to WeBWorK::Debug, removed WeBWorK::Timing. all existing calls to the WeBWorK::Timing methods now pass the same messages to debug(). added an option to WeBWorK::Debug to allow only certain subroutines to log debug messages, in addition to the existing option to bar certain subroutines from doing so.
added implementation of options() which call optionsMacro(). the version in Problem.pm takes care to preserve the editMode and sourceFilePath parameters.
add special case for no problems, closing bug #811.
Preliminary commit of changes to add Gateway module.
This adds to WeBWorK
- the ability to create versioned, timed problem sets ("gateway tests")
for which all problems are displayed on a single page ("versioned"
means that students can get multiple versions of the problem set),
- the ability to create sets that draw problems from groups of
problems, and
- the ability to create sets that require a proctor login to start
and grade.
Sets can be defined as gateway tests or proctored gateway tests from
the ProblemSetDetail page.
Not quite bug-free yet. Known bugs include handling of problem values
on the Student Progress page (I think this may be a problem with
changing from sql database format where all entries were 'text' to
sql_single in ver 2.1, where they are integer), and a division by zero
error on the grades page (which may be the same problem).
Tests with a number of attempts per version greater than one haven't
been carefully tested, nor has scoring of gateway tests.
renamed "problem set" to "homework set" in page content. closes bug #797.
(1) problem numbers are left alligned (2) problem values are listed (3) no special message is given if problem value is 0
Preserve display options when using the "up" arrow in navigation.
Some code that helps pass messages through {status_message} when a call
is redirected to ProblemSet (e.g. from PGproblemEditor.pm)
These changes elevate the Options panel to ContentGenerator.pm Some of the changes are a bit hackish, but I believe that they are sufficient for the moment. I expect much of the machinery to be replaced by an "options" table in the new database. The current options state consists of two values: displayMode (for viewing equations) and showOldAnswers (for showing answers between one session and the next). "Sticky answers" which show form entries when the form is submitted and returned is a feature which is always on, as I believe it should be. Known bugs: The options state is lost when visiting the Instructor pages, editing problems, and probably sending instructor feedback. (I have made sure that state was passed for the main links, I hope, but there are many other possible links where state can get lost. My hope is that storing state in the database will make it unnecessary to hunt down every link where state needs to be preserved.) Default options are set in the subroutine options in ContentGenerator.pm This is called before body, where the option panel is displayed, but not before the initialization phase. Modules that need options in the initialization phase (currently only Problem.pm) need to set them themselves.
eliminated warnings in cases where status is "".
rel-2-0-patches merge: fixes for invalid "published" field. Rob said: should finally fix bugs dealing with sets being created (usually from 1.9) without a valid setting in the published field now anyone of Problem, ProblemSet, or ProblemSets will correct this bug.
Don't show unpublished sets in the siblings list (unless of course you have permission to see unpublished sets. (published == visible, unpublished == hidden) This might be a little slow if there is a very long list of sibling sets. Each set has to be checked to see if it is published.
added permissions checks fixed bad logic on bad set/problem in URL as professor minor cosmetic changes
changed visable to visible. Closes #554.
fixed code order to avoid invalid call to published field on a non-existant set Fixes #543.
Made the list of problems more readable by using center alignment in the columns.
fixed display of published/unpublished text
Allready done so this should fail Arnie
added "This problem does not count towards your grade." messages if the weight of a problem has been set to 0. Fixes #464.
added functionality for published/unpublished
Removed debugging code
added error checking for invalid set numbers
Made a small change to the subroutine problemListRow which now handles the case where the problem status has not been defined as a number.
support for previewing temp files
URLpath compliance, some cleaning up of code. much more cleanup remains.
I have made changes to the list of problems that uses the full path instead of the relative call used previously. Hope this will fix the error described below. I don't know whether this is the proper fix or whether something fancier using urlPath is appropriate. There is an error with the links for Set 7. Clicking on problems in the problem set will not link to the selected problem- it will link to the problem set of the same number. (i.e. Selecting problem #2 will link me to Homework set #2 instead) --Mike
changed template escape handler functions to grab data from $r->urlpath instead of @_ for compatability with dispatch_new.
Rolled back previous addition of the due date. The due date can be specified in the setHeader message. It does not need to be hard coded into ProblemSet.pm --Mike
Cleaning up commented out code. Added a "due date is...." message to the top of the ProblemSet page.
As best I can determine all "get" commands to the database are now checked and appropriate action (usually "die") is taken if no object is returned. One exception. The multiple "gets" such as getGlobalSets(@setNames) are not checked -- if a given setName is not found is an empty object returned? in the list or is nothing returned? --Mike
Normalized headers. All files now contain the text below as a header. This is important since all files now (a) use the full name of the package, (b) assign copyright to "The WeBWorK Project", (c) give the full path of the file (relative to CVSROOT) instead of simply the file name, and (d) include license and warranty information. Here is the new header: ################################################################################ # WeBWorK Online Homework Delivery System # Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/ # $CVSHeader$ # # This program is free software; you can redistribute it and/or modify it under # the terms of either: (a) the GNU General Public License as published by the # Free Software Foundation; either version 2, or (at your option) any later # version, or (b) the "Artistic License" which comes with this package. # # This program is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the # Artistic License for more details. ################################################################################
I wasn't using WeBWorK::PG here, but it was getting loaded anyway before I changed the way the dispatcher loads things.
Fixed typo (set should have been self)
Made changes to ProblemSet.pm that replace the feedback button which did not work with the "email instructor" button. Also changed some probable typos in Feedback.pm which was trying to find set_id from problem rather than from set. This doesn't work when problem is not defined. --Mike
More cosmetic tweaks to the siblings macro --Mike
I've trade speed for usefulness and convenience. The sibling links are now sorted by name and all links are active. On webwork3 this cuts the loading time for the page by a factor of 5 (11 seconds to 2) We can reverse this when the process of collecting all of the relevant sets is faster (this process took 8 seconds). --Mike
Added link to edit set header. Available only to instructors --Mike
Changed the variable pointing to the text accompanying the list of problems from problem_header to set_header. I believe this is what was intended originally, since the default is snippets/setHeader.pg I don't believe we have a use for problem header yet. --Mike
housekeeping in siblings()
removed debugging output -sam
Fixed a bug in ordering the siblings. (again :-) ) --Mike
Added sortByName($field, @items) to WeBWorK::Utils. It uses the method named $field to sort the objects in @items. Modified ProblemSets to call it. -sam
Fixed bug in sorting in siblings subroutine --Mike
Siblings for problem set are sorted by date. Those sets which are still open are listed first, followed by sets which are now closed. Within each group the problems are sorted by due date in increasing order. This responds to bug #57bis (request for ordering by due-date) --Mike
*** empty log message ***
Modified sibiling macro to sort alphabetically by name of the set. (this may not be the best permanet solution but itis useful for those editing this summer.) --Mike
the % done status indicators now round to the nearest whole percent. Fixes Bug #47 -Dennis
changed ->id to ->whatever_id -sam
modev more content generators over to the new WWDBv2 API. fixed some bugs. -sam
changed the name of the "courseEnvironment" field in the ContentGenerator object to "ce", to match the style and conciesness of the existing "r" and new "db" fields. -sam
Hit the #nav macro with a cluebat RE: webworkURLs->htdocs vs. imageprefix="" -Dennis
Matched the calling semantics for navMacro -dennis
Added the <!--#nav--> macro to ProblemSet.pm. When I made a template that didn't include the <!--#path--> macro to satisfy some old timers on the mailing list, I noticed that there was no other way to get back to the problem sets page from a problem set. -Dennis
ProblemSet and Problem no longer allow problem sets that are "not yet open" to be viewed. oopsies. -sam
merged changes from rel-2-0-pr1-hardcopy-changes -sam
effectiveUser audit complete on all the content generators except Hardcopy -Dennis
&info now respects screen set header file in database. -sam
added feedback links to a bunch of modules. -sam
fixed image centering, added head escape. -sam
HTML_img mode ("images" mode in the HTML interface) now uses dvipng to
generate images. ProblemSet now has a link to Hardcopy.
-sam
updated copyright header. -sam
fixed problem with deciding when to generate images in math2img mode finished adding template escapes to ProblemSets, ProblemSet, and Problem fixed a problem where modules were removed from the courseEnv while being loaded (whups.) -sam
pretty much implemented the whole thing. yeah. -sam
"normalized" files: - (c) header on all files - standard order of preamble lines: 1. (c) header 2. package PACKAGENAME; 3. short summary of the package (pod's NAME section) 4. use - pragmatic modules 5. use - standard perl modules 6. use - CPAN modules 7. use - webwork modules - ALWAYS use strict and use warnings - use "use base" rather than "our @ISA" so now we can be happy. -sam
converted CGI calls to "CGI->" style to avoid import conflicts with &title and &body. -sam
Added use strict and use warnings, then cleaned up much of the mess that revealed. --Dennis
All of the content generators now work with the template system Moved the content generators into the WeBWorK::ContentGenerator namespace Added the default template and a few global.conf entries
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| aubreyja at gmail dot com | ViewVC Help |
| Powered by ViewVC 1.0.9 |