| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
This commit was manufactured by cvs2svn to create branch 'rel-2-3-dev'.
GatewayQuiz ProblemSets update: omit hardcopy checkbox or radio button for gateway template sets, clean up checking for gateway sets.
Parent DirectoryCommitting formatting changes to CGI calls
Adding {} to calls that concatenate their inputs
Changed submit button so that the name and label keys are explicitly entered.
Try using the -nosticky pragma to see if this fixes the problem.
Correctly handle viewing of edited files (we are passed relative paths, but the code used to treat them as absolute paths).
don't call formatDateTime unless the result is used (closes bug #830)
forward-port from rel-2-2-dev: (move [edit] link for Course/Set Info to top, resolving bug #978.)
forward-port from rel-2-2-dev: (security checks for sourceFilePath -- fixes bug #970.
* Utils.pm: add path_is_subdir
* Problem.pm: use path_is_subdir to check sourceFilePath
fix logic on when to use sourceFilePath
* ProblemSet.pm: use path_is_subdir to check sourceFilePath
add permissions check around sourceFilePath handler
* ProblemSets.pm: use path_is_subdir to check sourceFilePath
* GatewayQuiz.pm: remove code to preserve editMode/sourceFilePath (not used))
forward-port from rel-2-2-dev: (update copyright date range -- 2000-2006. this is probably overkill, since there are some files that were created after 2000 and some files that were last modified before 2006.)
forward-port from rel-2-2-dev: (remove extraneous instructor tools link)
forward-port: (update info() for new stylesheet.)
forward-port to head (roll back part of change in version 1.58.)
forward-port to head (partial clean up rendering of the info box. it will now not show up unless it has content, and the headings will be rendered more nicely.)
Merge changes with HEAD (Re-target view and edit links to use the view and edit windows)
Merging changes from rel-2-2-dev into HEAD
Gateway update: revise display of versioned and non-versioned sets. Now all regular sets are sorted to the top of the list, with gateway tests at the bottom. Use view_proctored_tests parameter to decide if proctored tests should be hidden. Now uses new listUserSets and listUserSetVersions routines from DB.
Use new hardcopy param names.
use new feedbackMacro()
Fixed some indenting.
added HiRes timing data to WeBWorK::Debug, removed WeBWorK::Timing. all existing calls to the WeBWorK::Timing methods now pass the same messages to debug(). added an option to WeBWorK::Debug to allow only certain subroutines to log debug messages, in addition to the existing option to bar certain subroutines from doing so.
Added a missing start_form and hidden authentication. These had been dropped in a recent revision. This closes bug #806
Preliminary commit of changes to add Gateway module.
This adds to WeBWorK
- the ability to create versioned, timed problem sets ("gateway tests")
for which all problems are displayed on a single page ("versioned"
means that students can get multiple versions of the problem set),
- the ability to create sets that draw problems from groups of
problems, and
- the ability to create sets that require a proctor login to start
and grade.
Sets can be defined as gateway tests or proctored gateway tests from
the ProblemSetDetail page.
Not quite bug-free yet. Known bugs include handling of problem values
on the Student Progress page (I think this may be a problem with
changing from sql database format where all entries were 'text' to
sql_single in ver 2.1, where they are integer), and a division by zero
error on the grades page (which may be the same problem).
Tests with a number of attempts per version greater than one haven't
been carefully tested, nor has scoring of gateway tests.
Added code to display {status_message} when call is redirected from
PGProblemEditor.pm
If course_info.txt does not exist as a file create it (using `echo "">course_info.txt`)
Hope that's not too dangerous, but I didn't feel like opening the file :-)
This keeps unnecessary warnings from occuring later when a user would be warned that the
course_info.txt file didn't exist.
These changes elevate the Options panel to ContentGenerator.pm Some of the changes are a bit hackish, but I believe that they are sufficient for the moment. I expect much of the machinery to be replaced by an "options" table in the new database. The current options state consists of two values: displayMode (for viewing equations) and showOldAnswers (for showing answers between one session and the next). "Sticky answers" which show form entries when the form is submitted and returned is a feature which is always on, as I believe it should be. Known bugs: The options state is lost when visiting the Instructor pages, editing problems, and probably sending instructor feedback. (I have made sure that state was passed for the main links, I hope, but there are many other possible links where state can get lost. My hope is that storing state in the database will make it unnecessary to hunt down every link where state needs to be preserved.) Default options are set in the subroutine options in ContentGenerator.pm This is called before body, where the option panel is displayed, but not before the initialization phase. Modules that need options in the initialization phase (currently only Problem.pm) need to set them themselves.
Tidying of set names: don't automatically write "set" (teacher can include that), and convert _ to non-breaking spaces in set name.
timezone support
rel-2-0-patches merge: fixes for invalid "published" field. Rob said: should finally fix bugs dealing with sets being created (usually from 1.9) without a valid setting in the published field now anyone of Problem, ProblemSet, or ProblemSets will correct this bug.
Applied Bill Wheeler's urgency-sort patch, fixing bug #601.
Added help escape handler specialized to handing a url with the course name in the path. The corresponding help file for this page is course home.
added permissions checks fixed bad logic on bad set/problem in URL as professor minor cosmetic changes
the published field is always defined but is empty if not yet set to 1 or 0 now if the published field is empty it is set to 1 this change can be undone once all sets have a published field set to 1 or 0
This fixes bug #510 in which sets which have no defined published state are now assumed to be published when viewed from the problemSets page.
added functionality for published/unpublished
Made changes in wording about open date. This foxes bug 429 (assuming that it really needed to be fixed).
new interface to systemLink
URLPath conversion, cosmetic changes, work on info box UI
disabled path() and title() so implementations in superclass will be used instead.
Added support for the new module Grades.pm which supports student grades Also changed ProblemSets.pm so that it welcomes the effectiveUser rather than the user.
Changes to the ways links are constructed on this, the front page, of WeBWorK. I believe this is where links missing webwork2 or missing the course name started to appear. In fact I'm surprised it worked at all. the current patches are hacks. This page needs to be adapted to URLpath. It would be a good script to do next. --Mike
Checked to make sure parameter is defined before using it.
Removed extraneous warning message
Made modifications to PG problem editor to allow editing of course_info. Future plans include allowing editing of login_info by the site manager (but not by the course instructors). All files to be edited must lie under the templates directory (for safety reasons.) There are still issues with adequate warnings for saving files when permissions are not correctly set. There is not yet a save as button. --Mike
changed text of link to instructor tools. (it is considered bad style to label links "Link to ...")
A link to the instructor tools is placed prominately at the top of the page. It is identical to the link to instructor tools on the left. This responds to bug #325, but may not close it completely.
Added a larger title to this page.
As best I can determine all "get" commands to the database are now checked and appropriate action (usually "die") is taken if no object is returned. One exception. The multiple "gets" such as getGlobalSets(@setNames) are not checked -- if a given setName is not found is an empty object returned? in the list or is nothing returned? --Mike
Normalized headers. All files now contain the text below as a header. This is important since all files now (a) use the full name of the package, (b) assign copyright to "The WeBWorK Project", (c) give the full path of the file (relative to CVSROOT) instead of simply the file name, and (d) include license and warranty information. Here is the new header: ################################################################################ # WeBWorK Online Homework Delivery System # Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/ # $CVSHeader$ # # This program is free software; you can redistribute it and/or modify it under # the terms of either: (a) the GNU General Public License as published by the # Free Software Foundation; either version 2, or (at your option) any later # version, or (b) the "Artistic License" which comes with this package. # # This program is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the # Artistic License for more details. ################################################################################
cleanup
Adding timing code for ProblemSets and for Stats.pm --Mike
Changed code to call getMergedSets instead of calling getMergedSet repeatedly. No noticable speed up in this case, but it works correctly. --Mike
Fixed bug in feeback button.
Squashed a bug in adding the title "sets " in listing the sets on the first page. --Mike
Added "set " before listing the set number. --Mike
Login reads material from login_info(.txt) in the top directory of the course and places on the right side of the page. ProblemSets does the same from a file called course_info.txt --Mike
Fixed bug 143 Implemented temporary solution suggested in bug 110 (I think this could be the permanent solution) Fixed bug 53
Corrected spelling on button --Mike
housekeeping
Added sortByName($field, @items) to WeBWorK::Utils. It uses the method named $field to sort the objects in @items. Modified ProblemSets to call it. -sam
*** empty log message ***
changed ->id to ->whatever_id -sam
modev more content generators over to the new WWDBv2 API. fixed some bugs. -sam
changed the name of the "courseEnvironment" field in the ContentGenerator object to "ce", to match the style and conciesness of the existing "r" and new "db" fields. -sam
1. fixed some formatting in Problem 2. hardcopy allows correct answers, hints, solutions to be shown 3. privileged users are allowed to view/download "not yet open" sets -sam
merged changes from rel-2-0-pr1-hardcopy-changes -sam
motd is only read if defined and true. -sam
effectiveUser audit complete on all the content generators except Hardcopy -Dennis
An MOTD can be displayed on the problem sets page. Define
$courseFiles{motd} to point to a file containing the message.
-sam
DONE effectiveUser for at least Problem.pm DONE write a template escape for printing $user, $effectiveUser, &c. nicely also added additional timing log points: timing is now logged: 1. when WeBWorK::PG::new starts 2. after all the initialization-type stuff happens 3. when WeBWorK::PG::new ends Getting it to log the entire request time might be a little harder. -sam
fixed formatting in &tth (dangerousMacros.pl) ProblemSets.pm allows sorting by Name or Status (due date) -sam
added feedback links to a bunch of modules. -sam
fixed the "Download Hardcopy for Selected Sets" button -sam
fixed image centering, added head escape. -sam
updated copyright header. -sam
pretty much implemented the whole thing. yeah. -sam
"normalized" files: - (c) header on all files - standard order of preamble lines: 1. (c) header 2. package PACKAGENAME; 3. short summary of the package (pod's NAME section) 4. use - pragmatic modules 5. use - standard perl modules 6. use - CPAN modules 7. use - webwork modules - ALWAYS use strict and use warnings - use "use base" rather than "our @ISA" so now we can be happy. -sam
more CGI fixes, started playing around with ProblemSets. -sam
converted CGI calls to "CGI->" style to avoid import conflicts with &title and &body. -sam
Added use strict and use warnings, then cleaned up much of the mess that revealed. --Dennis
Removed the CARP code (for now?), and made sure that an actual problem was reachable (even though PG evaluation is commented out in the dispatcher right now)
All of the content generators now work with the template system Moved the content generators into the WeBWorK::ContentGenerator namespace Added the default template and a few global.conf entries
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| aubreyja at gmail dot com | ViewVC Help |
| Powered by ViewVC 1.0.9 |