| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
backport (sh002i): Better messages when no recipients are selected -- resolves bug 1130.
Parent Directorybackport (sh002i): Set SMTP envelope sender to $ce->{mail}{smtpSender}
rather than user's from address. This prevents some mailservers from
rejecting the mail for having a forged sender address.
backport (sh002i): apache2 compatibility fixes
backport (sh002i): filter out students without "include_in_email" behavior - bug #938.
This commit was manufactured by cvs2svn to create branch 'rel-2-3-dev'.
Added {} to some HTML tags. For some reason they seem to have disappeared?
Added {} to force concatenation in some tables;
Mostly replace use CGI; with use WeBWorK::CGI Files with additional changes to CGI calls are SendMail, SetMaker PGProblemEditor Instructor::Index and FileManager
Try using the -nosticky pragma to see if this fixes the problem.
forward-port from rel-2-2-dev: (update copyright date range -- 2000-2006. this is probably overkill, since there are some files that were created after 2000 and some files that were last modified before 2006.)
get rid of submitError usage
Make notification message more explicit.
modify usage of user status to take advantage of new status system. the most extensive change is in UserList, where the names of statuses are now shown in the status column along with the abbreviation that's actually set in the database, and the edit popup shows the actual names that are defined in global.conf.
Restored changes that were accidentally clobbered when the gateway changes were checked in. Email now uses post processing to email students.
Preliminary commit of changes to add Gateway module.
This adds to WeBWorK
- the ability to create versioned, timed problem sets ("gateway tests")
for which all problems are displayed on a single page ("versioned"
means that students can get multiple versions of the problem set),
- the ability to create sets that draw problems from groups of
problems, and
- the ability to create sets that require a proctor login to start
and grade.
Sets can be defined as gateway tests or proctored gateway tests from
the ProblemSetDetail page.
Not quite bug-free yet. Known bugs include handling of problem values
on the Student Progress page (I think this may be a problem with
changing from sql database format where all entries were 'text' to
sql_single in ver 2.1, where they are integer), and a division by zero
error on the grades page (which may be the same problem).
Tests with a number of attempts per version greater than one haven't
been carefully tested, nor has scoring of gateway tests.
Moved the task of sending the emails to the students to a post_processing portion of the request handling. When you email a class, an HTML message is returned informing you that the messages will be sent. Once the process is completed an email notification is sent to the user (instructor) sending the email. This has been lightly tested.
Changed some UI features. In particular the scrolling list is now used both for selecting students to send mail to AND for selecting the preview message (if multiple students are selected the first is used as the preview). The "command table" is now one line taller than it was, but it it now effectively narrower (just two columns) -- the last column has only the row and column options and is not used that much.
Remove extraneous evals and also clean up email if no record exists in merge file. Arnie
Changed substitution as suggested by Sam Arnie
Make $COL[1], not $COL[0], the first column of the merge file. Also stop negative indexes from cycling, e.g. $COL[-12] should not give $COL[8] in a 10 column merge file. Arnie
Added default from, reply-to and subject values. The subject probably needs improvement, but will do for now.
added permissions checks
Edited Labels to make clear that "All students" meant all students in the course, not all students shown after filtering. This should eventually be fixed so that "All students" only refers to those who pass the filtering.
Updated to allow record filtering when selecting students
addmessage() used for success messages
dded use of addmessage() instead of warn and submitError
More user interface work on SendMai.pm Resolved bug #390 Now we simply report the number of students to which we have attempted to send email, rather than list the email addresses.
Modified user interface for choosing message to preview. Unresolved is the issue of bringing the preview up in a new window.
Modifications to remove extraneous error messages. This resolves bug 410
failure messages now given with addmessage() -- fixes bug #447 (sort of)
re-fixed getRecord subroutine to properly handle blank fields at the end of lines. (Adding a delimiter is not enough, perl deletes all terminal blank elements at the end of a list -- as far as I can determine.) One needs to add "$delimeter___" so that the last field is non-blank. This appears to fix bug #471
Fixed problem where a success message was issued even when a mail merge file was not correctly saved. Also made cosmetic modifications to the error message format so that it doesn't look as frightening and the important error message is highlited more than the boiler plate message
Fixed a line return that was causing troubles one webwork, but not on webwork3. "<br>\n" produced two line breaks within <pre> on webwork, but only one on webwork3, "\n" produced no line breaks on webwork3 and one on webwork. It seems safest to go with "<br>" which seems to produce a single line break on each machine.
Fixed spacing in preview of merge file data
Fixed errors in creating urls. (It is important to set authen=>0 when creating links for forms -- they already contain hidden authentication variables.
More changes in construction of urls. Changed parameter acquistion in ShowAnswers
Cleanup -- moving toward using the Apache:Request object and URLpath. It remains to use URLpath to construct new paths in these files.
Corrected sorting by user_id. Code now works correctly. Before the sorting for this case was occuring by accident with the SQL database. Made changes to the interface in SendMail. The radio buttons are now horizontal to match the radio buttons on the Instructor::Index page. Changed Id to Login to make the sorting parameter clearer. changed the format of the popmenu on the Instructor::Index page to match the format used on the SendMail page.
Mail merge does not report error when the merge file selected is "None". --Mike
Can now sort recipient list by section and rectation. A few other user interface cosmetics added. This should close bug 309
- Assigner and SetsAssignedToUser now refuse to unassign sets from the GlobalTableEmulator's "global user". Closes bug #283. - New "unassign from all users" button in Assigner. - Cosmetic changes to path() and title() in several modules.
users are now skipped if they don't have an email address.
As best I can determine all "get" commands to the database are now checked and appropriate action (usually "die") is taken if no object is returned. One exception. The multiple "gets" such as getGlobalSets(@setNames) are not checked -- if a given setName is not found is an empty object returned? in the list or is nothing returned? --Mike
Normalized headers. All files now contain the text below as a header. This is important since all files now (a) use the full name of the package, (b) assign copyright to "The WeBWorK Project", (c) give the full path of the file (relative to CVSROOT) instead of simply the file name, and (d) include license and warranty information. Here is the new header: ################################################################################ # WeBWorK Online Homework Delivery System # Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/ # $CVSHeader$ # # This program is free software; you can redistribute it and/or modify it under # the terms of either: (a) the GNU General Public License as published by the # Free Software Foundation; either version 2, or (at your option) any later # version, or (b) the "Artistic License" which comes with this package. # # This program is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the # Artistic License for more details. ################################################################################
removed "use HTML::Entities", as it is not being used (commented out) and no other modules use it.
Abstracted "read directory" functions in SendMail and moved them to Instructor. The instructor calls WeBWorK::Utils::readDirectory and then filters the output according to a pattern match. Sorts as well. Also move read_scoring_file to instructor since it will need to be used in other scripts as well. --Mike
Changed error message for merge template display --Mike
Some more initialization fixes. Still problems with the best error reporting if merge file hasn't been found or doesn't exist. --Mike
Fixed some bugs where defaults were not always initialized. --Mike
SendMail now works -- probably with lots of bugs and certainly without enough features, particularly error checks. It's ready for bug reports. --Mike
Preview now works fairly well. Only the actual send mail action needs to be implemented Followed by bug fixes and assignments. --Mike
backups work now. The list of merge files can be found. To do: 1.. Get better list of students (with entire names) 2. Get view of merge file 3. Get preview working --Mike
Save procedures are working pretty well although there is no backup mechanism yet. --Mike
Massive changes -- formatting is now much better. Functionality is not yet there. --Mike
First crack at writing a send mail script. Not at all functional --Mike
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| aubreyja at gmail dot com | ViewVC Help |
| Powered by ViewVC 1.0.9 |