Log of /trunk/webwork2/lib/WeBWorK/ContentGenerator/Feedback.pm
Parent Directory
Revision
3698 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 10 22:17:27 2005 UTC (7 years, 7 months ago) by
sh002i
File length: 14976 byte(s)
Diff to
previous 3688
added names to From: and To: email addresses, if users have names
defined. noted in global.conf.dist that feedbackRecipients can include
user names.
Revision
3688 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Oct 5 18:16:52 2005 UTC (7 years, 7 months ago) by
sh002i
File length: 14823 byte(s)
Diff to
previous 3648
Implemented status system as per bug #743.
The status system consists of a new hash in the course environment,
%statuses, that maps status names (like "Enrolled", "Drop", "Audit") to
(a) a list of allowed abbreviations for the status and (b) a list of
behaviors the system should have when dealing with users who have the
status.
I didn't want to have to mangle that hash-of-hashes-of-arrays myself in
many modules, but I also didn't want to devote an entire module
(Status.pm) to it. So, I'm trying a little experiment: I've added them
as methods to WeBWorK::CourseEnvironment. My thinkint is that since all
the data for these operations comes from the course environment, so why
not have them be course environment methods? Here they are:
status_abbrev_to_name($status_abbrev)
Given the abbreviation for a status, return the name. Returns undef
if the abbreviation is not found.
status_name_to_abbrevs($status_name)
Returns the list of abbreviations for a given status. Returns an
empty list if the status is not found.
status_has_behavior($status_name, $behavior)
Return true if $status_name lists $behavior.
status_abbrev_has_behavior($status_abbrev, $behavior)
Return true if the status abbreviated by $status_abbrev lists
$behavior.
Since I removed the previous $siteDefaults{status} hash from
global.conf, I have already switched modules that formerly used that
hash over to using the new methods:
Authen.pm: use status_abbrev_has_behavior($status, "allow_course_access")
to determine if a user should be allowed to log in.
Feedback.pm: look up status abbreviation using status_abbrev_to_name()
and print the result for the status field in the email.
Instructor.pm: use status_abbrev_has_behavior($status, "include_in_assignment")
to determine if a user should be included in an assignment.
UserList.pm and UsersAssignedToSet.pm: use status_abbrev_to_name() to
get name of CSS class.
Revision
3646 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 22 18:06:52 2005 UTC (7 years, 7 months ago) by
sh002i
File length: 14663 byte(s)
Diff to
previous 3645
since the subject line can be changed now, email filters would be wise
to rely on something more static. i've added X-WeBWorK-* headers to
accomodate this:
X-WeBWorK-Module
X-WeBWorK-Course
X-WeBWorK-User
X-WeBWorK-Section
X-WeBWorK-Recitation
X-WeBWorK-Set
X-WeBWorK-Problem
Revision
3645 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 22 17:48:38 2005 UTC (7 years, 7 months ago) by
sh002i
File length: 14167 byte(s)
Diff to
previous 3644
implement customizable feedback subject line. The following escape
sequences are recognized:
%c = course ID
%u = user ID
%s = set ID
%p = problem ID
%x = section
%r = recitation
%% = literal percent sign
Revision
3639 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Sep 19 16:25:41 2005 UTC (7 years, 8 months ago) by
sh002i
File length: 13896 byte(s)
Diff to
previous 3627
added nice custom formatting routines for user/set/problem data:
* uses "yes" and "no" for true/false values
* formats dates
* uses "unlimited" for -1 max_attempts
* uses pretty names for the status
* decodes the answer string
* lines up output
Revision
3627 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Sep 16 19:08:17 2005 UTC (7 years, 8 months ago) by
sh002i
File length: 10205 byte(s)
Diff to
previous 3623
feedback is now sent to users with receive_feedback permission
regardless of the contents of the feedbackRecipients list in
global.conf. Comments in global.conf now read:
By default, feeback is sent to all users who have permission to
receive_feedback. If this list is non-empty, feedback is also sent to
the addresses specified here.
* If you want to disable feedback altogether, leave this empty and set
submit_feeback => $nobody in %permissionLevels below. This will
cause the feedback button to go away as well.
* If you want to send email ONLY to addresses in this list, set
receive_feedback => $nodoy in %permissionLevels below.
It's often useful to set this in the course.conf to change the
behavior of feedback for a specific course.
Revision
3127 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jan 29 01:21:19 2005 UTC (8 years, 3 months ago) by
gage
File length: 9817 byte(s)
Diff to
previous 2849
CourseID is now part of the subject line when feedback is sent.
This allows you to filter out feedback by course, which is handy
for those of use receiving lots of feedback emails.
Revision
2724 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 2 22:53:00 2004 UTC (8 years, 8 months ago) by
sh002i
File length: 9402 byte(s)
Diff to
previous 2489
cleaned up mike's permission level patch to Feedback.pm:
- added receive_feedback permission (conf/global.conf.dist)
- use standard hasPermissions() function (lib/WeBWorK/ContentGenerator/Feedback.pm)
- check for undefined and empty string in permission field (lib/WeBWorK/Authz.pm)
Revision
1663 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Dec 9 01:12:32 2003 UTC (9 years, 5 months ago) by
sh002i
File length: 9989 byte(s)
Diff to
previous 1636
Normalized headers. All files now contain the text below as a header.
This is important since all files now (a) use the full name of the
package, (b) assign copyright to "The WeBWorK Project", (c) give the
full path of the file (relative to CVSROOT) instead of simply the file
name, and (d) include license and warranty information.
Here is the new header:
################################################################################
# WeBWorK Online Homework Delivery System
# Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/
# $CVSHeader$
#
# This program is free software; you can redistribute it and/or modify it under
# the terms of either: (a) the GNU General Public License as published by the
# Free Software Foundation; either version 2, or (at your option) any later
# version, or (b) the "Artistic License" which comes with this package.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the
# Artistic License for more details.
################################################################################
Revision
1502 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 11 02:03:06 2003 UTC (9 years, 8 months ago) by
gage
File length: 9180 byte(s)
Diff to
previous 1501
Made changes to ProblemSet.pm that replace the feedback button
which did not work with the "email instructor" button.
Also changed some probable typos in Feedback.pm which
was trying to find set_id from problem rather than from set.
This doesn't work when problem is not defined.
--Mike
Revision
1501 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 11 01:13:05 2003 UTC (9 years, 8 months ago) by
gage
File length: 9188 byte(s)
Diff to
previous 1478
Blank messages are not submitted and give a warning. I also fixed
a hidden bug in which the arguments to feebackForm were switched.
--Mike
Revision
1111 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 10 23:05:57 2003 UTC (9 years, 11 months ago) by
sh002i
File length: 8845 byte(s)
Diff to
previous 919
Added sortByName($field, @items) to WeBWorK::Utils. It uses the method
named $field to sort the objects in @items. Modified ProblemSets to call
it.
-sam
Revision
830 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed May 14 18:44:25 2003 UTC (10 years ago) by
malsyned
File length: 8882 byte(s)
Diff to
previous 818
Progress towards making the feedback system work more cleanly and
allowing a back-link. Except now it's broken.
-Dennis
Revision
809 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Apr 17 21:30:57 2003 UTC (10 years, 1 month ago) by
sh002i
File length: 7805 byte(s)
Diff to
previous 765
changed the name of the "courseEnvironment" field in the
ContentGenerator object to "ce", to match the style and conciesness of
the existing "r" and new "db" fields.
-sam
Revision
765 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Feb 28 23:56:35 2003 UTC (10 years, 2 months ago) by
malsyned
File length: 7835 byte(s)
Diff to
previous 740
removed "nowrap" from barebones.template because it wasn't doing
anything anyway, and every byte counts ;-)
Changed "Logged in as:" to "User:" in ContentGenerator and killed the
CGI::br calls in that message and the "Acting as:" message
Added more context to the context URL in Feedback, and properly
obfuscated some code.
--Dennis
Revision
740 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Feb 21 21:16:48 2003 UTC (10 years, 2 months ago) by
sh002i
File length: 7968 byte(s)
Diff to
previous 675
1. the new global.conf key {mail}->{feedbackVerbosity} controls the
verbosity level of Feedback.pm messages.
2. Feedback includes a URL when ever the user is logged in.
-sam
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
