Log of /trunk/webwork2/lib/WeBWorK/ContentGenerator/Instructor/PGProblemEditor.pm
Parent Directory
Revision
4258 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jul 14 21:22:04 2006 UTC (6 years, 10 months ago) by
gage
File length: 81896 byte(s)
Diff to
previous 4245
Minor formatting changes in CGI calls. Mostly adding {} at the beginning of functions that
concatenate their inputs.
Revision
4234 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jul 12 01:19:15 2006 UTC (6 years, 10 months ago) by
gage
File length: 81817 byte(s)
Diff to
previous 4216
Mostly replace use CGI; with use WeBWorK::CGI
Files with additional changes to CGI calls are
SendMail, SetMaker PGProblemEditor Instructor::Index and FileManager
Revision
4216 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jul 11 03:59:08 2006 UTC (6 years, 10 months ago) by
sh002i
File length: 81715 byte(s)
Diff to
previous 4202
Apache2 compatibility for HTTP constants. (This may very well be broken,
but I wanted to get it comitted before bed.)
Revision
4168 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 26 18:16:26 2006 UTC (6 years, 10 months ago) by
gage
File length: 81756 byte(s)
Diff to
previous 4167
The last message was garbled. I've added code that copies auxiliary files when you make a local copy or
an extra copy of a problem file of the form prob4/prob4.pg
This copy mechanism is not yet used when viewing one of these problems from a temporary file in tmpEdit. If you
have viewed a problem before you start editing it, your browser will probably use cached images and you
will not have any errors. If you start editing a problem with auxiliary files before viewing it once in its original
state, then some of the auxiliary images might be missing.
Revision
4167 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 26 18:05:52 2006 UTC (6 years, 10 months ago) by
gage
File length: 81758 byte(s)
Diff to
previous 4165
and copy auxilliary files when making a copy of a problem. This does not do anything about the creation of temporary files
for viewing. If you have already viewed the file before you start editing it youthen the temporary links will work.
Make
File::Copy available
Revision
4165 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jun 24 22:23:30 2006 UTC (6 years, 10 months ago) by
dpvc
File length: 79542 byte(s)
Diff to
previous 4164
Fixed a couple more issues with blank problems. Allow files to be
copied even when we can't write the original (this lets you make a
copy of the blank problem or default headers).
Attempt to overcome the copy/rename problem by making it not be a menu
and instead use a checkbox that says whether the problem or header
will replace the one in the current set. This makes it clear that a
copy is still being made (not that the original is being renamed), but
that the homework set is being altered. Those are really two
different actions, and it seems to make sense to separate them. The
default is still to link into the homework set, if there is one.
Revision
4164 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jun 24 21:12:29 2006 UTC (6 years, 10 months ago) by
dpvc
File length: 79209 byte(s)
Diff to
previous 4163
Changed messages that refer to 'Save as' to use 'Create a copy'
instead (which is the current wording for that function).
Problem: Since the default in that pop-up menu us "Rename file"
rather than "Create a copy", it is not immediately clear what this
message refers to.
I still think "Create a copy" should be the default rather than
"Rename file", since the latter only makes sense when you got to the
editor from a file linked to a homework set, which is not always the
case (e.g., when you use the Library Browser). It would also make
these error messages refer to something visible rather than a menu
item that is not showing.
Revision
4163 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jun 24 21:04:13 2006 UTC (6 years, 10 months ago) by
dpvc
File length: 79185 byte(s)
Diff to
previous 4162
Handle blank problems correctly (they were being flagged as unsafe in
some cases, and produced as many as 3 error messages indicating that
the file had to be "Saved as" before editing). Also fixed a typo with
hardcopy header checking.
Revision
3973 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jan 25 23:13:56 2006 UTC (7 years, 3 months ago) by
sh002i
File length: 77430 byte(s)
Diff to
previous 3907
forward-port from rel-2-2-dev: (update copyright date range -- 2000-2006.
this is probably overkill, since there are some files that were created
after 2000 and some files that were last modified before 2006.)
Revision
3876 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jan 7 01:14:54 2006 UTC (7 years, 4 months ago) by
gage
File length: 68727 byte(s)
Diff to
previous 3815
This fixes the bug specifically reported in bug report #935.
There are still problems with saving local copies of set headers.
Revision
3811 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Dec 14 00:16:50 2005 UTC (7 years, 5 months ago) by
gage
File length: 64179 byte(s)
Diff to
previous 3790
Removed a link for creating a blank problem that is not yet fully supported.
Commented out cheerful green goodmessages announcing which subroutine handler of the PGProblemEditor
was being executed. They seem to have fulfilled their role and are no longer needed. :-)
-- Mike
Revision
3790 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Dec 3 21:18:35 2005 UTC (7 years, 5 months ago) by
gage
File length: 64174 byte(s)
Diff to
previous 3779
Modifying messages given when editing set detail.
Also changed the way blank problems are handled in editor.
You can save as or save a copy as
Revision
3779 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Nov 22 01:44:55 2005 UTC (7 years, 6 months ago) by
gage
File length: 61066 byte(s)
Diff to
previous 3736
Modifications that set problems with path .../Library/setFoo/problemBar to reference the "Library" component in
bugzilla.
Also the problemSeed is added to the url sent to bugzilla e.g.
/webwork/shared-courses/gage_course_single_sql/templates/rochesterLibrary/setMAAtutorial/simplemultiplechoiceexample.pg_with_problemSeed=4655
this means that you can't click on the link, but it automatically includes a seed which might be helpful.
It is not guaranteed that this the seed that caused problems -- that depends on how the
bug is submitted -- but it is often the case that this seed caused the problem.
-- Mike
Revision
3736 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Nov 1 01:51:32 2005 UTC (7 years, 6 months ago) by
gage
File length: 60401 byte(s)
Diff to
previous 3726
Added rudimentary link to report problems directly. It does this by constructing a link
to the bugzilla CGI that includes information on the file name of the problem and the library
in which the problem is stored. This is probably still pretty fragile. A separate
module could be constructed to more intelligently report bugs.
-- Mike
Revision
3719 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 17 13:58:07 2005 UTC (7 years, 7 months ago) by
gage
File length: 57571 byte(s)
Diff to
previous 3718
Improved handling of case where a blank_problem is asked for in PGProblemEditor.pm
Also improved the random names for new local problems
Added ability to create a new blank problem in ProblemSetDetail.pm (without going to the PGProblemEditor.pm)
however something is not yet working when this problem record is saved.
Sam -- could you look at
lines near 679 to see what the problem is? There is a FIXME note there. I suspect that the addProblemToSet
routine is failing somehow, but there is no error message. Many of the record fields are not filled out --
including the sourceFile path and the number of attempts. The same snippet of code works fine
in PGProblemEditor.pm
--Mike
Revision
3718 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 17 03:42:42 2005 UTC (7 years, 7 months ago) by
gage
File length: 57352 byte(s)
Diff to
previous 3667
Refactored much of the action in PGProblemEditor.pm This allows a user inteface
which mimics the interface for the Hmwk sets editor and for the Classlist editor.
It also allows all of the temporary edit files to be placed in one location.
This allows one to "temporarily" edit a library file to try to see what is wrong with it.
It is also now much easier to make a local copy of a library file for your current problem set
so that you can tweak it.
It has been fairly well tested by one person (me) but there may still be bugs.
-- Mike
Revision
3667 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 29 01:57:56 2005 UTC (7 years, 7 months ago) by
gage
File length: 50560 byte(s)
Diff to
previous 3433
Allow making a local copy of a library problem with a single button push.
The user interface is still cluttered. I think I'll rewrite the bottom button rows
using radio buttons and a 'Take action' submit button as on the Classlist and Homework set editor
pages.
Revision
3433 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jul 30 17:26:45 2005 UTC (7 years, 9 months ago) by
gage
File length: 45624 byte(s)
Diff to
previous 3377
Added useful links to the macro list and the pod_docs
in addition to the incomplete manpages.
These are still temporary measures for improving the documentation
for those writing problems.
Revision
3377 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Jul 14 13:15:27 2005 UTC (7 years, 10 months ago) by
glarose
File length: 45310 byte(s)
Diff to
previous 3315
Preliminary commit of changes to add Gateway module.
This adds to WeBWorK
- the ability to create versioned, timed problem sets ("gateway tests")
for which all problems are displayed on a single page ("versioned"
means that students can get multiple versions of the problem set),
- the ability to create sets that draw problems from groups of
problems, and
- the ability to create sets that require a proctor login to start
and grade.
Sets can be defined as gateway tests or proctored gateway tests from
the ProblemSetDetail page.
Not quite bug-free yet. Known bugs include handling of problem values
on the Student Progress page (I think this may be a problem with
changing from sql database format where all entries were 'text' to
sql_single in ver 2.1, where they are integer), and a division by zero
error on the grades page (which may be the same problem).
Tests with a number of attempts per version greater than one haven't
been carefully tested, nor has scoring of gateway tests.
Revision
3175 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Feb 17 17:42:36 2005 UTC (8 years, 3 months ago) by
gage
File length: 45072 byte(s)
Diff to
previous 3128
Fixed error in PGProblemEditor.pm that prevented you from adding new problem in
a set. Added comment to ProblemSetDetail.pm
Revision
3128 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jan 29 01:23:57 2005 UTC (8 years, 3 months ago) by
gage
File length: 44938 byte(s)
Diff to
previous 3062
Fixed problem with hardcopy editing. This case had simply not been handled
in the code even though it's the same behavior for hardcopy headers as it is for
screen headers.
This fixes bug #763
Revision
3062 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Dec 21 18:44:49 2004 UTC (8 years, 5 months ago) by
gage
File length: 44711 byte(s)
Diff to
previous 3040
fixed error when set number or problem number is not defined
Kept fix that keeps set 0 and problem 0 from being replaced by blanks.
Revision
3037 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Dec 17 17:08:37 2004 UTC (8 years, 5 months ago) by
gage
File length: 44421 byte(s)
Diff to
previous 2809
Massive overhaul of this file to put dehackify the code, at least somewhat.
The cases for handling each file type and each action are pretty cleanly laid out.
The next reasonable step would be to reorganize the code by subclassing it.
Since in almost all cases the link knows what file type it wants to be edited
when it calls the editor, the links could specifically call the subclass editor.
This would either reduce or eliminate the need for the file_type parameter.
Properly done subclassing would make it easier to add a new file type.
Currently you need to add code in about four places: UI code in body,
action code in saveFileChanges, path finding code in getFilePaths,
and redirect code in pre_header_initialize.
For a subclass this code could all be adjacent.
Revision
2809 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Sep 21 20:07:48 2004 UTC (8 years, 8 months ago) by
toenail
File length: 25364 byte(s)
Diff to
previous 2474
Added ability to edit Hardcopy Header
If passed make_local_copy with any true value, assumes
that the file being edited is some type of library or default file
that should not be overwritten and the Save button is greyed out.
Stopped editor from trying to edit blank files or edit directories as files.
Revision
2456 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jul 7 18:42:03 2004 UTC (8 years, 10 months ago) by
gage
File length: 23779 byte(s)
Diff to
previous 2305
The bread crum path at the top leads back to the problem being edited, not to
the Instructor Tool. This is at least reasonable behavior.
This fixes bug #596
--Mike
Revision
2126 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue May 18 05:19:33 2004 UTC (9 years ago) by
jj
File length: 19092 byte(s)
Diff to
previous 2094
On refresh, make source file path relative to the templates directory. This
is needed to match the behavior of alias on static gif files.
Revision
2081 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue May 11 19:06:23 2004 UTC (9 years ago) by
gage
File length: 18929 byte(s)
Diff to
previous 2054
Added a surePathToFile call when saving a .pg problem. Now they can be saved in
a new directory. This is a partial solution to having a read only library.
More to come.
Revision
2054 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat May 8 19:35:21 2004 UTC (9 years ago) by
jj
File length: 18744 byte(s)
Diff to
previous 2032
Doing 'Save as' on a problem pops up a new PGProblemEditor window. Now
the new window contains the newly saved file. Also modified the name of
the target window since targets aren't supposed to start with _ (except
for the special reserved ones), and so that editting in the new window
and clicking on a button like Refresh will open yet another window.
Revision
1980 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Apr 28 15:51:25 2004 UTC (9 years ago) by
gage
File length: 17216 byte(s)
Diff to
previous 1924
Added code to give message when an edited problem file cannot be saved.
Some of the problems reported in bug #152 are addressed.
Instituting a submit result field was not done.
Revision
1841 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 4 21:05:58 2004 UTC (9 years, 2 months ago) by
sh002i
File length: 19090 byte(s)
Diff to
previous 1750
changed template escape handler functions to grab data from $r->urlpath
instead of @_ for compatability with dispatch_new.
Revision
1750 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Jan 25 18:20:14 2004 UTC (9 years, 3 months ago) by
gage
File length: 18846 byte(s)
Diff to
previous 1747
Added rudimentary "Save as" function. This duplicates
WW1.9 save as , but does not provide any extra functionality.
The following problems remain:
The redirect does not yet work correctly. I believe the desired behavior is to view the
new saved problem from the editor. There is no easy way to view the new problem
or whatever until the problem has been assigned to globalUser in the set.
Revision
1747 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Jan 25 15:53:23 2004 UTC (9 years, 3 months ago) by
gage
File length: 17628 byte(s)
Diff to
previous 1667
Made modifications to PG problem editor to allow editing of course_info.
Future plans include allowing editing of login_info by the site manager (but not
by the course instructors).
All files to be edited must lie under the templates directory (for safety reasons.)
There are still issues with adequate warnings for saving files when permissions are not correctly set.
There is not yet a save as button.
--Mike
Revision
1667 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Dec 12 02:24:30 2003 UTC (9 years, 5 months ago) by
gage
File length: 13881 byte(s)
Diff to
previous 1663
As best I can determine all "get" commands to the database are now
checked and appropriate action (usually "die") is taken if no
object is returned.
One exception. The multiple "gets" such as getGlobalSets(@setNames)
are not checked -- if a given setName is not found is an empty object
returned? in the list or is nothing returned?
--Mike
Revision
1663 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Dec 9 01:12:32 2003 UTC (9 years, 5 months ago) by
sh002i
File length: 13778 byte(s)
Diff to
previous 1591
Normalized headers. All files now contain the text below as a header.
This is important since all files now (a) use the full name of the
package, (b) assign copyright to "The WeBWorK Project", (c) give the
full path of the file (relative to CVSROOT) instead of simply the file
name, and (d) include license and warranty information.
Here is the new header:
################################################################################
# WeBWorK Online Homework Delivery System
# Copyright © 2000-2003 The WeBWorK Projcct, http://openwebwork.sf.net/
# $CVSHeader$
#
# This program is free software; you can redistribute it and/or modify it under
# the terms of either: (a) the GNU General Public License as published by the
# Free Software Foundation; either version 2, or (at your option) any later
# version, or (b) the "Artistic License" which comes with this package.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See either the GNU General Public License or the
# Artistic License for more details.
################################################################################
Revision
1591 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Oct 18 20:46:01 2003 UTC (9 years, 7 months ago) by
gage
File length: 12902 byte(s)
Diff to
previous 1363
Fixed problem in logic which kept an edited problem from reading the
.tmp file when the answer was submitted. Now the editMode variable
and sourceFilePath variables are passed on as hidden variables by
Problem.pm if they exists in the input form. This fixes bug #179
as well as bug #109.
The temporary file is now labeled fileName.pg.user.tmp where user is
the login name of the person editing the file. If that file exists
then pgProblemEditor will attempt to use that as a source file.
The revert button forces a read from fileName.pg
--Mike
Revision
1352 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jul 11 16:58:09 2003 UTC (9 years, 10 months ago) by
gage
File length: 13056 byte(s)
Diff to
previous 1348
When editing a set header one can not save to a temporary file, (the
refresh button is gone) however you can make a permanent change and the
result is viewed from the ProblemSet.pm page listing the problems from
the set, together with the screen version of the set header.
--Mike
Revision
1348 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jul 11 13:47:27 2003 UTC (9 years, 10 months ago) by
gage
File length: 12151 byte(s)
Diff to
previous 1295
Added a link which allows editing of the setHeader
Refresh and Save don't yet work because they try to
access the set header as problem 0. One fix would
be to have Problem.pm display the setHeader whenever
it was asked to show problem 0. This involves a fair
amount of special case code. Is there are better way?
--Mike
Revision
1105 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 10 17:29:27 2003 UTC (9 years, 11 months ago) by
gage
File length: 10655 byte(s)
Diff to
previous 1044
Filter problem contents before saving to disk to handle line ending problems.
All occurences of \r\n and \r are replaced by \n.
Began improving the error messages if files cannot not be read.
Revision
991 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 3 20:12:42 2003 UTC (9 years, 11 months ago) by
gage
File length: 13150 byte(s)
Diff to
previous 983
The pgProblemEditor now looks for a global problem record if it cannot
find a global_user problem record.
-- Mike
Revision
983 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 3 17:48:35 2003 UTC (9 years, 11 months ago) by
malsyned
File length: 12555 byte(s)
Diff to
previous 981
Changed explicit references to "/webwork" to the abstract
$ce->{webworkURLs}->{root}. If you've been hardcoding "/webwork" into
your URLs, you should take a look at the diff to this update to learn
the prefered method.
-Dennis
Revision
981 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 3 00:28:28 2003 UTC (9 years, 11 months ago) by
gage
File length: 12536 byte(s)
Diff to
previous 980
Replaced temporary values placed in $self->{ce}->{foo}
by $self->{foo} in order to avoid editing the course environment
unnecessarily. Fixes bug #35
--Mike
Revision
980 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 2 23:10:59 2003 UTC (9 years, 11 months ago) by
malsyned
File length: 12597 byte(s)
Diff to
previous 929
Rearranged the order of functions in PGProblemEditor.pm
Removed an extraneous warning from ProblemSetEditor.pm
-Dennis
Revision
925 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed May 28 03:30:45 2003 UTC (9 years, 11 months ago) by
gage
File length: 12057 byte(s)
Diff to
previous 902
Problem Editor now creates a temporary file to edit (
adding .tmp to the file name)
Refresh causes a redirect to the Problem.pm with a GET command.
Some of the arguments are unnecessary and need to be cleaned up.
The seed and display mode in the problem editor are not properly
initialized from the problem set.
Problem.pm has been modified to check for these arguments and to read
the temporary source file, seed and displayMode. These are passed
through to a PG.pm object.
PG also needed to be modified so that the source_file and seed values
are overridden
Revision
892 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri May 23 13:14:51 2003 UTC (10 years ago) by
gage
File length: 6259 byte(s)
Diff to
previous 889
The script now reads takes the form data in problemContents
and displays it in a textarea form. If there is no problemContents
it reads from the file in template directory.
The script is called with .../instructor/pgProblemEditor/set10/prob1
I'm using the
current convention for labeling files in the template directory.
Using '10' for set10 will not work right at the moment. .pg
and the course template directory are combined with the path components
to determine the path to the file.
It remains to add the rest of the editing buttons and provide a method
for saving to the template file.
-- Mike
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
