Log of /trunk/webwork2/lib/WeBWorK/ContentGenerator/Instructor/ProblemSetDetail.pm
Parent Directory
Revision
3102 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jan 25 21:22:35 2005 UTC (8 years, 4 months ago) by
toenail
File length: 45756 byte(s)
Diff to
previous 3061
display mode was inadvertently reset with other problem/set elements
that are safe to reset (rather than keep sticky) since they will be updated
from the newly saved database record or thrown away as expected
Revision
3061 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Dec 21 17:47:57 2004 UTC (8 years, 5 months ago) by
toenail
File length: 45730 byte(s)
Diff to
previous 3046
Fixed minor display problem where empty (not-overriden) date values
were being displayed as 12/31/1969
Closes #748
Revision
3046 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Dec 18 21:22:20 2004 UTC (8 years, 5 months ago) by
gage
File length: 45476 byte(s)
Diff to
previous 3036
Modifications to make sure that problems with weight 0
print weight as 0 rather than as a blank.
This addresses bug #730
Revision
2913 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Oct 13 01:55:15 2004 UTC (8 years, 7 months ago) by
sh002i
File length: 44698 byte(s)
Diff to
previous 2904
optimizations in database access (makes a big difference).
My notes:
Here's the initial timing data for a set with 10 problems:
TIMING 57300 2 1097622363.881851 (16.734902) mth162: END (assumed)
$mergedRecord is never used in FieldHTML(). However, it is populated
with a merged set or problem, which requires two database calls and a
merge operation. It appears to be OK to get rid of these calls
altogether.
TIMING 57582 0 1097624803.340321 (11.219321) mth162: END (assumed)
i'm not as worried about the several DB calls in
handle_problem_numbers(), since that only happens when "Save Changes" is
clicked. not looking at those for now...
in initialize(), the global set is fetched from the database at the
beginning (and put into $setRecord). then it is fetched again in two
places, first in a conditional if the "submit_changes" param is defined,
and then in the following conditional, when "submit_changes" is defined
and there was no error. taking this out...
(those conditionals are pretty weird to begin with. i would have
expected something more like "if (submit_changes) { ... unless (error) {
... } }". probably from grafting code together?)
ok, the big one is getting pre-fetched records into FieldHTML. I added
$setRecord and $problemRecord parameters to FieldHTML (and $Set and
$Problem parameters to FieldTable to pass through to FieldHTML), and
pre-fetch GlobalProblems, UserProblems, and MergedProblems en masse
before going through the problem IDs in body().
TIMING 58456 0 1097632191.012939 (4.516615) mth162: END (assumed)
And it's only a little more than that when viewing for a particular
user:
TIMING 58453 0 1097632169.074723 (6.513201) mth162: END (assumed)
Revision
2834 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Sep 27 19:08:47 2004 UTC (8 years, 7 months ago) by
toenail
File length: 39384 byte(s)
Diff to
previous 2817
Preserves sticky values on all form submissions
Added reset form button to delete any unsaved changes
Added file error messgaes for headers and problems with
non-existant, invalid, or duplicate filenames
Revision
2816 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 23 12:59:53 2004 UTC (8 years, 8 months ago) by
toenail
File length: 36994 byte(s)
Diff to
previous 2807
Added ComboBoxes for header information
Allows user to enter a user specified value
or to select from currently existing header files
Revision
2794 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Added
Fri Sep 17 19:40:42 2004 UTC (8 years, 8 months ago) by
toenail
File length: 34559 byte(s)
Replaces ProblemSetEditor.pm and ProblemList.pm as primary form of editing
set/problem information.
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
