Features & Development

Proposed patch for ContentGenerator/Problem.pm

Proposed patch for ContentGenerator/Problem.pm

by Sarunas Burdulis -
Number of replies: 5
I would like to ask developers to make a simple change from '-label' into '-value' in line 1139 of ContentGenerator/Problem.pm. This will produce consistent submit button labels across browsers (problem pointed out in this Using Webwork forum post: http://webwork.maa.org/moodle/mod/forum/discuss.php?d=2853).

SVN diff file attached.

Thanks,
Sarunas

In reply to Sarunas Burdulis

Re: Proposed patch for ContentGenerator/Problem.pm

by Michael Gage -
Hi Sarunas,

I believe this was fixed a couple of years ago, probably when we rewrote the Problem.pm file to make it more accessible to screen readers.  Have you tried versions of WW from the last two years? (See http://webwork.maa.org/wiki/Category:Release_Notes and/or https://github.com/openwebwork)

-- Mike

In reply to Michael Gage

Re: Proposed patch for ContentGenerator/Problem.pm

by Sarunas Burdulis -
Mike,
Thank you for the info.

I was hoping to be running the latest stable by means of regular SVN updates, no?

webwork:/opt/webwork/webwork2# svn info
Path: .
URL: http://svn.webwork.maa.org/system/trunk/webwork2
Repository Root: http://svn.webwork.maa.org/system
Repository UUID: c0722133-6baf-4dd8-8699-98d999cd4f06
Revision: 7146
Node Kind: directory
Schedule: normal
Last Changed Author: glarose
Last Changed Rev: 7046
Last Changed Date: 2011-09-16 14:05:29 -0400 (Fri, 16 Sep 2011)
In reply to Sarunas Burdulis

Re: Proposed patch for ContentGenerator/Problem.pm

by Michael Gage -
The SVN repo will stay around, but it's been frozen for almost a year.  


You can use the svn client to download updates from the github repository --
(see http://webwork.maa.org/wiki/Github near the bottom of the page)
 but it's nearly as easy to install a git client and use that.  This also gives you
some extra features such as the ability to switch between versions of WW
quickly.


In reply to Michael Gage

Re: Proposed patch for ContentGenerator/Problem.pm

by Dick Lane -
Examples at bottom of
    http://webwork.maa.org/wiki/Github
show checkout of webwork and pg, but an
    svn update
of an existing NationalProblemLibrary is not documented.  (And the linked documentation at github only cites an svn update for something already checked-out from github via svn.)

I suspect some flavor of
    svn switch
will need to precede an "svn update" from github.
In reply to Dick Lane

Re: Proposed patch for ContentGenerator/Problem.pm

by Michael Gage -
svn checkout https://github.com/openwebwork/webwork-open-problem-library/trunk   webwork-open-problem-library

Works for me.  You can also do

svn update